linux-kernel - Re: [PATCH] fs/netfs3: add a boundary check for EA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2022 14:16:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     eadavis@...a.com,
        syzbot+c4d950787fd5553287b7@...kaller.appspotmail.com
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        almaz.alexandrovich@...agon-software.com,
        linux-kernel@...r.kernel.org, nathan@...nel.org,
        ndesaulniers@...gle.com, ntfs3@...ts.linux.dev,
        syzkaller-bugs@...glegroups.com, trix@...hat.com,
        Edward Adam Davis <eadvis@...a.com>
Subject: Re: [PATCH] fs/netfs3: add a boundary check for EA_FULL

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.0-rc5 next-20220909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/eadavis-sina-com/fs-netfs3-add-a-boundary-check-for-EA_FULL/20220912-114458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 80e78fcce86de0288793a0ef0f6acf37656ee4cf
config: i386-randconfig-a014-20220912
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2d169c3ed66886da971be5f3c6c24137ee7877d6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review eadavis-sina-com/fs-netfs3-add-a-boundary-check-for-EA_FULL/20220912-114458
        git checkout 2d169c3ed66886da971be5f3c6c24137ee7877d6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> fs/ntfs3/xattr.c:73:4: error: expected ')'
                           return false;
                           ^
   fs/ntfs3/xattr.c:69:6: note: to match this '('
                   if (next_len >= bytes ||
                      ^
   1 error generated.


vim +73 fs/ntfs3/xattr.c

    38	
    39	/*
    40	 * find_ea
    41	 *
    42	 * Assume there is at least one xattr in the list.
    43	 */
    44	static inline bool find_ea(const struct EA_FULL *ea_all, u32 bytes,
    45				   const char *name, u8 name_len, u32 *off)
    46	{
    47		*off = 0;
    48	
    49		if (!ea_all || !bytes)
    50			return false;
    51	
    52		for (;;) {
    53			const struct EA_FULL *ea = Add2Ptr(ea_all, *off);
    54			u32 next_off = *off + unpacked_ea_size(ea);
    55			u32 next_len = 0;
    56	
    57			if (next_off > bytes)
    58				return false;
    59	
    60			if (ea->name_len == name_len &&
    61			    !memcmp(ea->name, name, name_len))
    62				return true;
    63	
    64			*off = next_off;
    65			if (next_off >= bytes)
    66				return false;
    67	
    68			next_len = next_off + 8;
    69			if (next_len >= bytes ||
    70			    ((!ea->size) &&
    71			     (next_len + ea->name_len + 
    72			      le16_to_cpu(ea->elength) >= bytes))
  > 73				return false;
    74		}
    75	}
    76	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (157949 bytes)