[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220914032159.94812-1-linyujun809@huawei.com>
Date: Wed, 14 Sep 2022 11:21:59 +0800
From: Lin Yujun <linyujun809@...wei.com>
To: <a.zummo@...ertech.it>, <alexandre.belloni@...tlin.com>,
<mcoquelin.stm32@...il.com>, <alexandre.torgue@...s.st.com>,
<wsa@...nel.org>, <akpm@...ux-foundation.org>, <wim@...ana.be>
CC: <linux-rtc@...r.kernel.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: [PATCH -next] rtc: stmp3xxx: Add failure handling for stmp3xxx_wdt_register()
Use platform_device_put() to free platform device before print
error message when platform_device_add() fails to run. Add dev_err()
to report error in case of alloc memory to wdt_pdev fail.
Fixes: 1a71fb84fda6 ("rtc: stmp3xxx: add wdt-accessor function")
Signed-off-by: Lin Yujun <linyujun809@...wei.com>
---
drivers/rtc/rtc-stmp3xxx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/rtc/rtc-stmp3xxx.c b/drivers/rtc/rtc-stmp3xxx.c
index 40c0f7ed36e0..b2f4b034cdb6 100644
--- a/drivers/rtc/rtc-stmp3xxx.c
+++ b/drivers/rtc/rtc-stmp3xxx.c
@@ -107,6 +107,11 @@ static void stmp3xxx_wdt_register(struct platform_device *rtc_pdev)
wdt_pdev->dev.parent = &rtc_pdev->dev;
wdt_pdev->dev.platform_data = &wdt_pdata;
rc = platform_device_add(wdt_pdev);
+ if (rc)
+ platform_device_put(wdt_pdev);
+ } else {
+ dev_err(&rtc_pdev->dev,
+ "failed to allocate stmp3xxx_rtc_wdt\n");
}
if (rc)
--
2.17.1
Powered by blists - more mailing lists