linux-kernel - Re: [PATCH -next] rtc: stmp3xxx: Add failure handling for stmp3xxx_wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyJdf1AswoJNUcu0@shikoro>
Date:   Thu, 15 Sep 2022 00:02:23 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Lin Yujun <linyujun809@...wei.com>
Cc:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
        akpm@...ux-foundation.org, wim@...ana.be,
        linux-rtc@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] rtc: stmp3xxx: Add failure handling for
 stmp3xxx_wdt_register()

> +		if (rc)
> +			platform_device_put(wdt_pdev);

This is correct, thanks.

> +	} else {
> +		dev_err(&rtc_pdev->dev,
> +			"failed to allocate stmp3xxx_rtc_wdt\n");

This is superfluous because rc is initialized to -1.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)