linux-kernel - Re: [PATCH v9,5/7] arm64: dts: mt8195: Add efuse node to mt8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <064cd527-a975-a12f-a00b-3e6da3dbecb5@collabora.com>
Date:   Wed, 14 Sep 2022 14:23:28 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     bchihi@...libre.com, rafael@...nel.org, rui.zhang@...el.com,
        daniel.lezcano@...aro.org, amitk@...nel.org
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        khilman@...libre.com, mka@...omium.org, robh+dt@...nel.org,
        krzk+dt@...nel.org, matthias.bgg@...il.com, p.zabel@...gutronix.de,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, james.lo@...iatek.com,
        fan.chen@...iatek.com, louis.yu@...iatek.com,
        rex-bc.chen@...iatek.com, abailon@...libre.com
Subject: Re: [PATCH v9,5/7] arm64: dts: mt8195: Add efuse node to mt8195

Il 17/08/22 10:07, bchihi@...libre.com ha scritto:
> From: Alexandre Bailon <abailon@...libre.com>
> 
> Add efuse node.
> This will be required by the thermal driver to get the calibration data.
> 
> Signed-off-by: Alexandre Bailon <abailon@...libre.com>
> Co-developed-by: Balsam CHIHI <bchihi@...libre.com>
> Signed-off-by: Balsam CHIHI <bchihi@...libre.com>
> ---
>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 066c14989708..95967a0196d8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -733,6 +733,18 @@ u2_intr_p3: usb2-intr-p3@189,2 {
>   				reg = <0x189 0x2>;
>   				bits = <7 5>;
>   			};
> +
> +			lvts_efuse_data1: lvts1-calib@1bc {
> +				reg = <0x1bc 0x14>;
> +			};
> +
> +			lvts_efuse_data2: lvts2-calib@1d0 {
> +				reg = <0x1d0 0x38>;
> +			};
> +
> +			svs_calibration: calib@580 {

The SVS calibration efuse is for the SVS driver, not for the LVTS.
Moreover, you're not using it later when you add the LVTS nodes, so, please
drop this one.

Regards,
Angelo