linux-kernel - Re: [PATCH v9,6/7] arm64: dts: mt8195: Add thermal zones and thermal nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57039109-bf86-bd91-3b71-531e45fcb68f@collabora.com>
Date:   Wed, 14 Sep 2022 14:25:32 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     bchihi@...libre.com, rafael@...nel.org, rui.zhang@...el.com,
        daniel.lezcano@...aro.org, amitk@...nel.org
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        khilman@...libre.com, mka@...omium.org, robh+dt@...nel.org,
        krzk+dt@...nel.org, matthias.bgg@...il.com, p.zabel@...gutronix.de,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, james.lo@...iatek.com,
        fan.chen@...iatek.com, louis.yu@...iatek.com,
        rex-bc.chen@...iatek.com, abailon@...libre.com
Subject: Re: [PATCH v9,6/7] arm64: dts: mt8195: Add thermal zones and thermal
 nodes

Il 17/08/22 10:07, bchihi@...libre.com ha scritto:
> From: Tinghan Shen <tinghan.shen@...iatek.com>
> 
> Add thermal zones and thermal nodes for the mt8195.
> 
> Signed-off-by: Tinghan Shen <tinghan.shen@...iatek.com>
> Co-developed-by: Ben Tseng <ben.tseng@...iatek.com>
> Signed-off-by: Ben Tseng <ben.tseng@...iatek.com>
> Co-developed-by: Alexandre Bailon <abailon@...libre.com>
> Signed-off-by: Alexandre Bailon <abailon@...libre.com>
> Co-developed-by: Balsam CHIHI <bchihi@...libre.com>
> Signed-off-by: Balsam CHIHI <bchihi@...libre.com>
> ---
>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 111 +++++++++++++++++++++++
>   1 file changed, 111 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 95967a0196d8..aafbbe83e6ba 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -10,6 +10,7 @@
>   #include <dt-bindings/interrupt-controller/irq.h>
>   #include <dt-bindings/phy/phy.h>
>   #include <dt-bindings/pinctrl/mt8195-pinfunc.h>
> +#include <dt-bindings/reset/mt8195-resets.h>
>   
>   / {
>   	compatible = "mediatek,mt8195";
> @@ -452,6 +453,28 @@ spi0: spi@...0a000 {
>   			status = "disabled";
>   		};
>   
> +		lvts_ap: thermal-sensor@...0b000 {
> +			compatible = "mediatek,mt8195-lvts-ap";
> +			#thermal-sensor-cells = <1>;
> +			reg = <0 0x1100b000 0 0x1000>;
> +			interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH 0>;
> +			clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
> +			resets = <&infracfg_ao MT8195_INFRA_RST0_THERM_CTRL_SWRST>;
> +			nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
> +			nvmem-cell-names = "lvts_calib_data1", "lvts_calib_data2";
> +		};
> +
> +		lvts_mcu: thermal-sensor@...78000 {

Please keep the devicetree nodes ordered by address.
This one must be moved between mmc@...5000 and usb@...90000.

Regards,
Angelo

> +			compatible = "mediatek,mt8195-lvts-mcu";
> +			#thermal-sensor-cells = <1>;
> +			reg = <0 0x11278000 0 0x1000>;
> +			interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
> +			clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
> +			resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
> +			nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
> +			nvmem-cell-names = "lvts_calib_data1", "lvts_calib_data2";
> +		};
> +
>   		spi1: spi@...10000 {
>   			compatible = "mediatek,mt8195-spi",
>   				     "mediatek,mt6765-spi";