linux-kernel - Re: [PATCH v5 5/5] gpio: pca953x: Add support for PCAL6534

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZBTfnRaFRLDb_OW5oGbtdC2=3VnrM1EL=_SmPVHBX-eQ@mail.gmail.com>
Date:   Thu, 15 Sep 2022 10:31:46 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Martyn Welch <martyn.welch@...labora.co.uk>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        Martyn Welch <martyn.welch@...labora.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 5/5] gpio: pca953x: Add support for PCAL6534

On Wed, Sep 14, 2022 at 5:16 PM Martyn Welch
<martyn.welch@...labora.co.uk> wrote:

> From: Martyn Welch <martyn.welch@...labora.com>
>
> Add support for the NXP PCAL6534. This device is broadly a 34-bit version
> of the PCAL6524. However, whilst the registers are broadly what you'd
> expect for a 34-bit version of the PCAL6524, the spacing of the registers
> has been compacted. This has the unfortunate effect of breaking the bit
> shift based mechanism that is employed to work out register locations used
> by the other chips supported by this driver. To accommodate ths, callback
> functions have been added to allow alterate implementations of
> pca953x_recalc_addr() and pca953x_check_register() for the PCAL6534.
>
> Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL6534.pdf
> Datasheet: https://www.diodes.com/assets/Datasheets/PI4IOE5V6534Q.pdf
> Signed-off-by: Martyn Welch <martyn.welch@...labora.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij