linux-kernel - Re: [PATCH 1/3] drm/mediatek: dp: Refactor drivers in mtk_dp_bdg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47c6f2a3-ad38-c9c6-544b-5b2d1a234593@collabora.com>
Date:   Thu, 15 Sep 2022 12:34:06 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Bo-Chen Chen <rex-bc.chen@...iatek.com>, chunkuang.hu@...nel.org,
        p.zabel@...gutronix.de, airlied@...ux.ie
Cc:     matthias.bgg@...il.com, granquet@...libre.com, daniel@...ll.ch,
        jitao.shi@...iatek.com, ck.hu@...iatek.com,
        liangxu.xu@...iatek.com, dri-devel@...ts.freedesktop.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH 1/3] drm/mediatek: dp: Refactor drivers in
 mtk_dp_bdg_detect()

Il 15/09/22 09:50, Bo-Chen Chen ha scritto:
> It is more clear to modify this in mtk_dp_bdg_detect().

I agree with this commit. Since you anyway have to send a v2 of this series,
please clarify the commit description and title, something like:

drm/mediatek: dp: Reduce indentation in mtk_dp_bdg_detect()

In order to improve human readability, reduce the indentation by returning
early if the dp/edp cable is not plugged in.

Cheers,
Angelo