linux-kernel - Re: [PATCH v2 1/2] random: move add_hwgenerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Sep 2022 08:22:53 +0200
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Sven van Ashbrook <svenva@...omium.org>
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Olivia Mackall <olivia@...enic.com>,
        Alex Levin <levinale@...gle.com>,
        Andrey Pronin <apronin@...gle.com>,
        Stephen Boyd <swboyd@...gle.com>,
        Rajat Jain <rajatja@...gle.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Petr Mladek <pmladek@...e.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Theodore Ts'o <tytso@....edu>, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v2 1/2] random: move add_hwgenerator_randomness()'s wait
 outside function

Am Thu, Sep 15, 2022 at 02:54:24PM -0400 schrieb Sven van Ashbrook:
> Dominik, Jason,
> 
> On Thu, Sep 15, 2022 at 11:44 AM Jason A. Donenfeld <Jason@...c4.com> wrote:
> >
> > Isn't Dominik working on the same thing, but slightly different?
> 
> I don't believe Dominik is working on quite the same thing, but his
> work will conflict with mine for sure:
> https://lore.kernel.org/lkml/YxiXEJ6up6XEW8SM@zx2c4.com/T/
> 
> What are the odds that two people are making changes to the hwrng
> kthread at the same time?
> 
> I see two possible ways forward:
> 1. Dominik rebases his patch against mine (iff mine finds favour).
> This may simplify his patch
> quite a bit, because the delayed_work abstraction tends to have fewer
> footguns than
> kthread.
> 
> or
> 
> 2. I rebase against Dominik's.
> 
> Both are fine with me, just let me know what you think.

Indeed, our patches address different issues. I'm fine with both approaches,
i.e. my patches to be based on Sven's, or the other way round.

Best,
	Dominik