linux-kernel - Re: [PATCH] media: dt-bindings: ov5645: Convert OV5645 binding to a schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a01b1cc-6d00-715c-1e21-b8836a64a9a0@linaro.org>
Date:   Fri, 16 Sep 2022 11:28:30 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Lad, Prabhakar" <prabhakar.csengg@...il.com>,
        Tommaso Merciai <tommaso.merciai@...rulasolutions.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] media: dt-bindings: ov5645: Convert OV5645 binding to a
 schema

On 16/09/2022 11:24, Lad, Prabhakar wrote:
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - clocks
>>> +  - clock-names
>>> +  - clock-frequency
>>> +  - vdda-supply
>>> +  - vddd-supply
>>> +  - vdddo-supply
>>> +  - enable-gpios
>>> +  - reset-gpios
>>> +  - port
>>
>> I think we don't need all of these properties as required.
>> The only "really" required are:
>>
>>   - compatible
>>   - reg
>>   - clocks
>>   - port
>>
> Agreed, it's just the driver requirement hence the previous bindings
> had marked them as required.

Please mention the change from pure conversion (with reason) in the
commit msg.


Best regards,
Krzysztof