linux-kernel - RE: [PATCH] mm/hugetlbfs: use macro SZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6fe4a3c252a34199b715e4e941fb2be7@AcuMS.aculab.com>
Date:   Fri, 16 Sep 2022 11:47:42 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'haoxin' <xhao@...ux.alibaba.com>,
        Al Viro <viro@...iv.linux.org.uk>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mike.kravetz@...cle.com" <mike.kravetz@...cle.com>,
        "songmuchun@...edance.com" <songmuchun@...edance.com>,
        SeongJae Park <sj@...nel.org>
Subject: RE: [PATCH] mm/hugetlbfs: use macro SZ_1K to replace 1024

From: haoxin
> Sent: 15 September 2022 03:45
> 
> åœ¨ 2022/9/15 ä¸Šå�ˆ12:43, Al Viro å†™é�“:
> > On Wed, Sep 14, 2022 at 07:57:23PM +0800, Xin Hao wrote:
> >> Using macro SZ_1K in hugetlbfs_show_options() has no any functional
> >> changes, just makes code more readable.
> > Why is it any more readable that way?

> The main purpose of this code is to convert size to 'K', and 'M'. I
> think using SZ_1k does look more appropriate than 1024, that's all.

You'd need to use SZ_1M/SZ_1K if you want to be descriptive.
But really it just uses up more brain cycles to read.

Using named constants for things that are absolutely constant
isn't really necessary.

If you have '#define ONE 1' are you ever going to set it to
a different value?

And don't even think about what happens to systems that had
small integer constants at 'well known' addresses and then
managed to change one of them.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)