lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 16 Sep 2022 10:25:35 +0200
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     cgel.zte@...il.com, broonie@...nel.org
Cc:     cezary.rojewski@...el.com, liam.r.girdwood@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com, yung-chuan.liao@...ux.intel.com,
        ranjani.sridharan@...ux.intel.com, kai.vehmanen@...ux.intel.com,
        perex@...ex.cz, tiwai@...e.com, brent.lu@...el.com,
        akihiko.odaki@...il.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] ASoC: Intel: sof_ssp_amp: use devm_kcalloc()
 instead of devm_kzalloc()



On 9/16/22 08:25, cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Use 2-factor multiplication argument form devm_kcalloc() instead
> of devm_kzalloc().
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

> ---
>  sound/soc/intel/boards/sof_ssp_amp.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/sof_ssp_amp.c b/sound/soc/intel/boards/sof_ssp_amp.c
> index 4a762e002ac7..94d25aeb6e7c 100644
> --- a/sound/soc/intel/boards/sof_ssp_amp.c
> +++ b/sound/soc/intel/boards/sof_ssp_amp.c
> @@ -210,10 +210,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev,
>  	struct snd_soc_dai_link *links;
>  	int i, id = 0;
>  
> -	links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) *
> -					sof_ssp_amp_card.num_links, GFP_KERNEL);
> -	cpus = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link_component) *
> -					sof_ssp_amp_card.num_links, GFP_KERNEL);
> +	links = devm_kcalloc(dev, sof_ssp_amp_card.num_links,
> +					sizeof(struct snd_soc_dai_link), GFP_KERNEL);
> +	cpus = devm_kcalloc(dev, sof_ssp_amp_card.num_links,
> +					sizeof(struct snd_soc_dai_link_component), GFP_KERNEL);
>  	if (!links || !cpus)
>  		return NULL;
>  
> @@ -306,9 +306,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev,
>  	if (sof_ssp_amp_quirk & SOF_HDMI_PLAYBACK_PRESENT) {
>  		/* HDMI */
>  		if (hdmi_num > 0) {
> -			idisp_components = devm_kzalloc(dev,
> -					   sizeof(struct snd_soc_dai_link_component) *
> -					   hdmi_num, GFP_KERNEL);
> +			idisp_components = devm_kcalloc(dev,
> +					   hdmi_num,
> +					   sizeof(struct snd_soc_dai_link_component),
> +					   GFP_KERNEL);
>  			if (!idisp_components)
>  				goto devm_err;
>  		}

Powered by blists - more mailing lists