linux-kernel - Re: [PATCH linux-next] ASoC: Intel: sof_rt5682: use devm_kcalloc() instead of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Sep 2022 10:25:52 +0200
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     cgel.zte@...il.com, broonie@...nel.org
Cc:     alsa-devel@...a-project.org, cezary.rojewski@...el.com,
        linux-kernel@...r.kernel.org, kai.vehmanen@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com, Zeal Robot <zealci@....com.cn>,
        tiwai@...e.com, ranjani.sridharan@...ux.intel.com,
        liam.r.girdwood@...ux.intel.com, mac.chiang@...el.com,
        ye xingchen <ye.xingchen@....com.cn>, ajye.huang@...il.com,
        yung-chuan.liao@...ux.intel.com, brent.lu@...el.com,
        vamshi.krishna.gopal@...el.com, yong.zhi@...el.com
Subject: Re: [PATCH linux-next] ASoC: Intel: sof_rt5682: use devm_kcalloc()
 instead of devm_kzalloc()



On 9/16/22 08:26, cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Use 2-factor multiplication argument form devm_kcalloc() instead
> of devm_kzalloc().
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>


> ---
>  sound/soc/intel/boards/sof_rt5682.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c
> index 045965312245..1bf9455eaf93 100644
> --- a/sound/soc/intel/boards/sof_rt5682.c
> +++ b/sound/soc/intel/boards/sof_rt5682.c
> @@ -600,10 +600,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev,
>  	struct snd_soc_dai_link *links;
>  	int i, id = 0;
>  
> -	links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) *
> -			     sof_audio_card_rt5682.num_links, GFP_KERNEL);
> -	cpus = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link_component) *
> -			     sof_audio_card_rt5682.num_links, GFP_KERNEL);
> +	links = devm_kcalloc(dev, sof_audio_card_rt5682.num_links,
> +			    sizeof(struct snd_soc_dai_link), GFP_KERNEL);
> +	cpus = devm_kcalloc(dev, sof_audio_card_rt5682.num_links,
> +			    sizeof(struct snd_soc_dai_link_component), GFP_KERNEL);
>  	if (!links || !cpus)
>  		goto devm_err;
>  
> @@ -687,9 +687,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev,
>  
>  	/* HDMI */
>  	if (hdmi_num > 0) {
> -		idisp_components = devm_kzalloc(dev,
> -				   sizeof(struct snd_soc_dai_link_component) *
> -				   hdmi_num, GFP_KERNEL);
> +		idisp_components = devm_kcalloc(dev,
> +				   hdmi_num,
> +				   sizeof(struct snd_soc_dai_link_component),
> +				   GFP_KERNEL);
>  		if (!idisp_components)
>  			goto devm_err;
>  	}