linux-kernel - Re: [PATCH] scsi: qedf: Fix a UAF bug in __qedf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166329729477.12731.17768877694121234425.b4-ty@oracle.com>
Date:   Thu, 15 Sep 2022 23:01:55 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     skashyap@...vell.com, Letu Ren <fantasquex@...il.com>,
        jejb@...ux.ibm.com, jhasan@...vell.com
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org, Wende Tan <twd2.me@...il.com>,
        Zheyu Ma <zheyuma97@...il.com>, linux-scsi@...r.kernel.org,
        GR-QLogic-Storage-Upstream@...vell.com
Subject: Re: [PATCH] scsi: qedf: Fix a UAF bug in __qedf_probe

On Fri, 12 Nov 2021 20:06:41 +0800, Letu Ren wrote:

> In __qedf_probe, if `qedf->cdev` is NULL which means
> qed_ops->common->probe() failed, then the program will goto label err1,
> scsi_host_put() will free `lport->host` pointer. Because the memory `qedf`
> points to is allocated by libfc_host_alloc(), it will be freed by
> scsi_host_put(). However, the if statement below label err0 only checks
> whether qedf is NULL but doesn't check whether the memory has been freed.
> So a UAF bug occurred.
> 
> [...]

Applied to 6.0/scsi-fixes, thanks!

[1/1] scsi: qedf: Fix a UAF bug in __qedf_probe
      https://git.kernel.org/mkp/scsi/c/fbfe96869b78

-- 
Martin K. Petersen	Oracle Linux Engineering