linux-kernel - Re: [PATCH] staging: rtl8192e: fix CamelCase struct member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyciAPSyyusp1eCR@kroah.com>
Date:   Sun, 18 Sep 2022 15:49:52 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Valentin Vidic <vvidic@...entin-vidic.from.hr>
Cc:     Philipp Hortmann <philipp.g.hortmann@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: fix CamelCase struct member

On Sun, Sep 18, 2022 at 01:49:26PM +0200, Valentin Vidic wrote:
> Fix checkpatch warnings for struct member pFirmware.
> 
> Signed-off-by: Valentin Vidic <vvidic@...entin-vidic.from.hr>
> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c      | 8 ++++----
>  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 ++--
>  drivers/staging/rtl8192e/rtl8192e/rtl_core.c        | 8 ++++----
>  drivers/staging/rtl8192e/rtl8192e/rtl_core.h        | 2 +-
>  4 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index 4b9249195b5a..6308a25e064c 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -707,19 +707,19 @@ bool rtl92e_start_adapter(struct net_device *dev)
>  		rtl92e_writeb(dev, ANAPAR, 0x37);
>  		mdelay(500);
>  	}
> -	priv->pFirmware->status = FW_STATUS_0_INIT;
> +	priv->pfirmware->status = FW_STATUS_0_INIT;

What does "pfirmware" mean here?

If you fix up camelcase warnings, please do so in a way that is the
proper Linux kernel style, not just making everything lowercase.

Look up Hungarian notation and why the original was named this way and
why this isn't needed in Linux at all (i.e. we have modern compilers.)

thanks,

greg k-h