linux-kernel - Re: [PATCH] staging: rtl8192e: fix CamelCase struct member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 18 Sep 2022 20:42:32 +0200
From:   Valentin Vidić <vvidic@...entin-vidic.from.hr>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Philipp Hortmann <philipp.g.hortmann@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: fix CamelCase struct member

On Sun, Sep 18, 2022 at 03:49:52PM +0200, Greg Kroah-Hartman wrote:
> What does "pfirmware" mean here?
> 
> If you fix up camelcase warnings, please do so in a way that is the
> proper Linux kernel style, not just making everything lowercase.
> 
> Look up Hungarian notation and why the original was named this way and
> why this isn't needed in Linux at all (i.e. we have modern compilers.)

The rest of the driver does not use Hungarian notation, so I assume this
was something like platform or packed firmware. However, I could not
find any more info in the git log, so maybe just drop the prefix as it
is the only firmware in that struct?

-- 
Valentin