linux-kernel - Re: [PATCH V3 04/11] um: Improve panic notifiers consistency and ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2087154222.237106.1663535981252.JavaMail.zimbra@nod.at>
Date:   Sun, 18 Sep 2022 23:19:41 +0200 (CEST)
From:   Richard Weinberger <richard@....at>
To:     "Guilherme G. Piccoli" <gpiccoli@...lia.com>
Cc:     Johannes Berg <johannes@...solutions.net>,
        linux-um <linux-um@...ts.infradead.org>,
        kexec@...ts.infradead.org, bhe@...hat.com,
        Petr Mladek <pmladek@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-hyperv@...r.kernel.org, netdev <netdev@...r.kernel.org>,
        x86 <x86@...nel.org>, kernel-dev@...lia.com, kernel@...ccoli.net,
        halves@...onical.com, fabiomirmar@...il.com,
        alejandro j jimenez <alejandro.j.jimenez@...cle.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Arnd Bergmann <arnd@...db.de>, bp <bp@...en8.de>,
        Jonathan Corbet <corbet@....net>,
        d hatayama <d.hatayama@...fujitsu.com>,
        dave hansen <dave.hansen@...ux.intel.com>, dyoung@...hat.com,
        feng tang <feng.tang@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        mikelley@...rosoft.com,
        hidehiro kawai ez <hidehiro.kawai.ez@...achi.com>,
        jgross@...e.com, John Ogness <john.ogness@...utronix.de>,
        Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...nel.org>, mhiramat@...nel.org,
        mingo <mingo@...hat.com>, paulmck@...nel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>, senozhatsky@...omium.org,
        stern@...land.harvard.edu, tglx <tglx@...utronix.de>,
        vgoyal@...hat.com, vkuznets@...hat.com, will@...nel.org,
        xuqiang36@...wei.com,
        anton ivanov <anton.ivanov@...bridgegreys.com>
Subject: Re: [PATCH V3 04/11] um: Improve panic notifiers consistency and
 ordering

----- Ursprüngliche Mail -----
> Von: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
> On 19/08/2022 19:17, Guilherme G. Piccoli wrote:
>> Currently the panic notifiers from user mode linux don't follow
>> the convention for most of the other notifiers present in the
>> kernel (indentation, priority setting, numeric return).
>> More important, the priorities could be improved, since it's a
>> special case (userspace), hence we could run the notifiers earlier;
>> user mode linux shouldn't care much with other panic notifiers but
>> the ordering among the mconsole and arch notifier is important,
>> given that the arch one effectively triggers a core dump.
>> 
>> Fix that by running the mconsole notifier as the first panic
>> notifier, followed by the architecture one (that coredumps).
>> 
>> Cc: Anton Ivanov <anton.ivanov@...bridgegreys.com>
>> Cc: Johannes Berg <johannes@...solutions.net>
>> Cc: Richard Weinberger <richard@....at>
>> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...lia.com>
>> 
>> V3:
>> - No changes.
>> [...]
> 
> Hi Johannes, sorry for the ping. Do you think you could pick this one?
> Or if you prefer, I can resend it alone (not in the series) - let me
> know your preference.

This patch is on my TODO list.
Just had no chance to test it.

Thanks,
//richard