lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Sep 2022 10:07:21 +0100 From: Marc Zyngier <maz@...nel.org> To: Dongliang Mu <dzm91@...t.edu.cn> Cc: Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Dongliang Mu <mudongliangabcd@...il.com>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] gpio: tqmx86: fix uninitialized variable girq On Mon, 19 Sep 2022 04:12:49 +0100, Dongliang Mu <dzm91@...t.edu.cn> wrote: > > From: Dongliang Mu <mudongliangabcd@...il.com> > > The commit 924610607f19 ("gpio: tpmx86: Move PM device over to > irq domain") adds a dereference of girq that may be uninitialized. > > Fix this by moving irq_domain_set_pm_device into if true branch > as suggested by Marc Zyngier. > > Fixes: 924610607f19 ("gpio: tpmx86: Move PM device over to irq domain") > Suggested-by: Marc Zyngier <maz@...nel.org> > Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com> > --- > v1->v2: modify fix method to moving irq_domain_set_pm_device into > if true branch as suggested by Marc Zyngier > drivers/gpio/gpio-tqmx86.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Marc Zyngier <maz@...nel.org> M. -- Without deviation from the norm, progress is not possible.
Powered by blists - more mailing lists