[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yygx3M4ALtIpWbu7@kroah.com>
Date: Mon, 19 Sep 2022 11:09:48 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Kang Minchul <tegongkang@...il.com>
Cc: Hans de Goede <hdegoede@...hat.com>,
Fabio Aiuto <fabioaiuto83@...il.com>,
Kees Cook <keescook@...omium.org>,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block
comment
On Sun, Sep 18, 2022 at 03:11:30AM +0900, Kang Minchul wrote:
> This patch removes the following warning generated by checkpatch.pl
>
> WARNING: Block comments use * on subsequent lines
> #206: FILE: rtw_recv.c:206:
> +/*
> +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
>
> WARNING: Block comments use * on subsequent lines
> #216: FILE: rtw_recv.c:216:
> +/*
> +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
>
> Signed-off-by: Kang Minchul <tegongkang@...il.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..ad6fb6c3d1f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> }
>
> /*
> -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> -{
> - return rtw_free_recvframe(precvframe, queue);
> -}
> -*/
> + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> + * {
> + * return rtw_free_recvframe(precvframe, queue);
> + * }
> + */
I agree with Dan, just remove these unused functions please.
thanks,
greg k-h
Powered by blists - more mailing lists