linux-kernel - Re: [PATCH] fs/ntfs3: "add a boundary check for EA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YyhHowvgEarPqONR@kadam>
Date:   Mon, 19 Sep 2022 13:42:43 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     eadavis@...a.com
Cc:     lkp@...el.com, almaz.alexandrovich@...agon-software.com,
        eadvis@...a.com, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        nathan@...nel.org, ndesaulniers@...gle.com, ntfs3@...ts.linux.dev,
        syzbot+c4d950787fd5553287b7@...kaller.appspotmail.com,
        syzkaller-bugs@...glegroups.com, trix@...hat.com
Subject: Re: [PATCH] fs/ntfs3: "add a boundary check for EA_FULL" lose right
 parenthesis

On Mon, Sep 19, 2022 at 01:19:43PM +0800, eadavis@...a.com wrote:
> From: Edward Adam Davis <eadavis@...a.com>
> 
> I have provided a new patch:
> https://lore.kernel.org/all/20220912065431.3043731-1-eadavis@sina.com
> It is a collection of the current patch and the previous one.
> 
> Signed-off-by: Edward Adam Davis <eadavis@...a.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: syzbot+c4d950787fd5553287b7@...kaller.appspotmail.com

No need to send this email.  The correct thing was to send a v2 which
fixes the bug and you already did that.  However your v2 patch was
missing a list of changes.  "v2: don't break the build".

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

You will want to address the review comments I sent and send a v3 patch.

regards,
dan carpenter