linux-kernel - Re: [PATCH] arm64: dts: renesas: rzg2ul-smarc-som: Drop enabling wdt2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2022 11:44:05 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] arm64: dts: renesas: rzg2ul-smarc-som: Drop enabling wdt2

On Mon, Sep 19, 2022 at 11:15 AM Biju Das <biju.das.jz@...renesas.com> wrote:
>
> Hi Geert,
>
> Prabhakar Mahadev Lad <prabhakar.mahadev-
> > lad.rj@...renesas.com>
> > Subject: Re: [PATCH] arm64: dts: renesas: rzg2ul-smarc-som: Drop
> > enabling wdt2
> >
> > Hi Biju,
> >
> > On Mon, Sep 19, 2022 at 12:06 PM Biju Das <biju.das.jz@...renesas.com>
> > wrote:
> > > > On Sun, Sep 18, 2022 at 10:04 AM Geert Uytterhoeven <geert@...ux-
> > > > m68k.org> wrote:
> > > > > On Wed, Sep 14, 2022 at 3:43 PM Prabhakar
> > > > <prabhakar.csengg@...il.com> wrote:
> > > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > > > > >
> > > > > > WDT CH2 is specifically to check the operation of Cortex-M33
> > CPU
> > > > so
> > > > > > don't enable WDT2 by default.
> > > > > >
> > > > For consistency I'll drop enabling WDT2 from the RZ/G2L{C} too.
> > >
> > > Does remove unused clocks turn off WDT2 clock during late init??
> > >
> > > If that is the case, we should remove entries from clock table as
> > well?
> >
> > Or add it to *_crit_mod_clks[]?
> >
> > Note that drivers/clk/renesas/r9a07g043-cpg.c creates wdt2 clocks and
> > resets, so that should probably be moved inside the #ifdef
> > CONFIG_ARM64 section.
>
Yes we dont want it to be listed on RZ/Five.

> Yes, both will do, I guess otherwise WDT enabled by Cortex-M33 will be disabled by
> CORTEX-A55 during boot.
>
Agreed.

Cheers,
Prabhakar