linux-kernel - Re: [PATCH v3] pinctrl: ocelot: Fix interrupt controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ec019b32b7221237ccf84fabf07e63d@walle.cc>
Date:   Tue, 20 Sep 2022 16:25:06 +0200
From:   Michael Walle <michael@...le.cc>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     horatiu.vultur@...rochip.com, UNGLinuxDriver@...rochip.com,
        andy.shevchenko@...il.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] pinctrl: ocelot: Fix interrupt controller

Am 2022-09-20 14:34, schrieb Michael Walle:
> Am 2022-09-20 14:28, schrieb Linus Walleij:

>> Just checking: since these drivers obviously must pass pass
>> IRQF_SHARED, have you also made sure that each driver also
>> will properly return IRQ_HANDLED if the interrupt was for them
>> (triggered by "their" hardware) but IRQ_NONE if the interrupt was
>> not for them (triggered by something else)?
> 
> Thanks, I'll check it.

The gpy driver seems to handle that correctly. The micrel one introduced
a regression some time ago. I've send a fix in the meantime [1], but it
doesn't help for the multiple interrupts here.

-michael

[1] 
https://lore.kernel.org/netdev/20220920141619.808117-1-michael@walle.cc/