linux-kernel - Re: [PATCH v4 02/10] tty: serial: clean up stop-tx part in altera_uart_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 16:17:17 +0200
From:   Tobias Klauser <tklauser@...tanz.ch>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     gregkh@...uxfoundation.org,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 02/10] tty: serial: clean up stop-tx part in
 altera_uart_tx_chars()

On 2022-09-20 at 07:20:42 +0200, Jiri Slaby <jslaby@...e.cz> wrote:
> The "stop TX" path in altera_uart_tx_chars() is open-coded, so:
> * use uart_circ_empty() to check if the buffer is empty, and
> * when true, call altera_uart_stop_tx().
> 
> Cc: Tobias Klauser <tklauser@...tanz.ch>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Acked-by: Tobias Klauser <tklauser@...tanz.ch>