linux-kernel - Re: [PATCH v2] HID: nintendo: check analog user calibration for plausibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 18:06:27 -0400
From:   Daniel Ogorchock <djogorchock@...il.com>
To:     Johnothan King <johnothanking@...tonmail.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH v2] HID: nintendo: check analog user calibration for plausibility

>  static const u16 DFLT_STICK_CAL_CEN = 2000;
>  static const u16 DFLT_STICK_CAL_MAX = 3500;
>  static const u16 DFLT_STICK_CAL_MIN = 500;
> +static void joycon_use_default_calibration(struct joycon_ctlr *ctlr,
> +                                          struct joycon_stick_cal *cal_x,
> +                                          struct joycon_stick_cal *cal_y,
> +                                          const char *stick, int ret)
> +{
> +       hid_warn(ctlr->hdev,
> +                "Failed to read %s stick cal, "
> +                "using defaults; e=%d\n",
> +                stick, ret);
> +

Sorry, missed this on my first readthrough. I think the coding style
mentions not to break up the logged string into multiple lines, since
it'll harm greppability.

-Daniel