linux-kernel - Re: [PATCH v2] HID: nintendo: check analog user calibration for plausibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2022 00:46:23 +0000
From:   Johnothan King <johnothanking@...tonmail.com>
To:     Daniel Ogorchock <djogorchock@...il.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH v2] HID: nintendo: check analog user calibration for plausibility

I'll submit a third version that fixes the warning string. I've also
made another minor tweak to joycon_use_default_calibration() for
the v3 patch.

- Johnothan King

------- Original Message -------
On Tuesday, September 20th, 2022 at 3:06 PM, Daniel Ogorchock <djogorchock@...il.com> wrote:


> > static const u16 DFLT_STICK_CAL_CEN = 2000;
> > static const u16 DFLT_STICK_CAL_MAX = 3500;
> > static const u16 DFLT_STICK_CAL_MIN = 500;
> > +static void joycon_use_default_calibration(struct joycon_ctlr *ctlr,
> > + struct joycon_stick_cal *cal_x,
> > + struct joycon_stick_cal *cal_y,
> > + const char *stick, int ret)
> > +{
> > + hid_warn(ctlr->hdev,
> > + "Failed to read %s stick cal, "
> > + "using defaults; e=%d\n",
> > + stick, ret);
> > +
> 
> 
> Sorry, missed this on my first readthrough. I think the coding style
> mentions not to break up the logged string into multiple lines, since
> it'll harm greppability.
> 
> -Daniel