linux-kernel - RE: [PATCH -next] crypto: aspeed - Fix check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HK0PR06MB32020D94813ECDFE5F16B900804C9@HK0PR06MB3202.apcprd06.prod.outlook.com>
Date:   Tue, 20 Sep 2022 05:24:58 +0000
From:   Neal Liu <neal_liu@...eedtech.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "joel@....id.au" <joel@....id.au>,
        "andrew@...id.au" <andrew@...id.au>,
        Johnny Huang <johnny_huang@...eedtech.com>,
        "dphadke@...ux.microsoft.com" <dphadke@...ux.microsoft.com>
CC:     "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] crypto: aspeed - Fix check for platform_get_irq()
 errors

> The platform_get_irq() function returns negative on error and positive non-zero
> values on success. It never returns zero, but if it did then treat that as a
> success.
> 
> Also remove redundant dev_err() print as platform_get_irq() already prints an
> error.
> 
> Fixes: 108713a713c7 ("crypto: aspeed - Add HACE hash driver")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Neal Liu <neal_liu@...eedtech.com>

> ---
>  drivers/crypto/aspeed/aspeed-hace.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/aspeed/aspeed-hace.c
> b/drivers/crypto/aspeed/aspeed-hace.c
> index 3f880aafb6a2..f7f1d33defb1 100644
> --- a/drivers/crypto/aspeed/aspeed-hace.c
> +++ b/drivers/crypto/aspeed/aspeed-hace.c
> @@ -130,10 +130,8 @@ static int aspeed_hace_probe(struct platform_device
> *pdev)
> 
>  	/* Get irq number and register it */
>  	hace_dev->irq = platform_get_irq(pdev, 0);
> -	if (!hace_dev->irq) {
> -		dev_err(&pdev->dev, "Failed to get interrupt\n");
> +	if (hace_dev->irq < 0)
>  		return -ENXIO;
> -	}
> 
>  	rc = devm_request_irq(&pdev->dev, hace_dev->irq, aspeed_hace_irq, 0,
>  			      dev_name(&pdev->dev), hace_dev);
> --
> 2.17.1