linux-kernel - Re: [PATCH] hw_random: rockchip: import driver from vendor tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YymMjpeHWV3d+64d@zx2c4.com>
Date:   Tue, 20 Sep 2022 11:49:02 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Robin Murphy <robin.murphy@....com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Corentin Labbe <clabbe@...libre.com>,
        Lin Jinhan <troy.lin@...k-chips.com>, wevsty <ty@...s.org>,
        Mikhail Rudenko <mike.rudenko@...il.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Lin Huang <hl@...k-chips.com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        linux-rockchip@...ts.infradead.org,
        Kyle Copperfield <kmcopper@...win1210.de>
Subject: Re: [PATCH] hw_random: rockchip: import driver from vendor tree

Hi Robin,

On Tue, Sep 20, 2022 at 10:35:44AM +0100, Robin Murphy wrote:
> On 2022-09-19 22:00, Jason A. Donenfeld wrote:
> > The Rockchip driver has long existed out of tree, but not upstream.
> > There is support for it upstream in u-boot, but not in Linux proper.
> > This commit imports the GPLv2 driver written by Lin Jinhan, together
> > with the DTS and config blobs from Wevsty.
> 
> Note that Corentin has a series enabling the full crypto driver for 
> RK3328 and RK3399[1], so it would seem more sensible to add TRNG support 
> to that. Having confliciting compatibles for the same hardware that 
> force the user to change their DT to choose one functionality or the 
> other isn't good (plus there's also no binding for this one).

Kyle, CC'd, pointed out the same thing to me. He apparently has already
done the work to have a hwrng ontop of that series. So hopefully it's
just a matter of having everyone coordinate.

So I'll duck out and let you guys handle it. Just please make sure the
thing you're rejecting this for does actually come to fruition.

Kyle, should you send your thing to Corentin?

Jason