linux-kernel - Re: [PATCH] hw_random: rockchip: import driver from vendor tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzMm4d3sZBHpitm9@aurel32.net>
Date:   Tue, 27 Sep 2022 18:37:53 +0200
From:   Aurelien Jarno <aurelien@...el32.net>
To:     Robin Murphy <robin.murphy@....com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Corentin Labbe <clabbe@...libre.com>
Cc:     Lin Jinhan <troy.lin@...k-chips.com>, wevsty <ty@...s.org>,
        Mikhail Rudenko <mike.rudenko@...il.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Lin Huang <hl@...k-chips.com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH] hw_random: rockchip: import driver from vendor tree

On 2022-09-20 10:35, Robin Murphy wrote:
> On 2022-09-19 22:00, Jason A. Donenfeld wrote:
> > The Rockchip driver has long existed out of tree, but not upstream.
> > There is support for it upstream in u-boot, but not in Linux proper.
> > This commit imports the GPLv2 driver written by Lin Jinhan, together
> > with the DTS and config blobs from Wevsty.
> 
> Note that Corentin has a series enabling the full crypto driver for 
> RK3328 and RK3399[1], so it would seem more sensible to add TRNG support 
> to that. Having confliciting compatibles for the same hardware that 
> force the user to change their DT to choose one functionality or the 
> other isn't good (plus there's also no binding for this one).

It might make sense for the cryptov1-rng driver (I haven't checked). For
the cryptov2-rng driver, I looked at the RK3568 TRM (I can't find the
RK3588 one), and from what I understand crypto and TRNG are two
different devices, using different address spaces, clock, reset and
interrupts. The vendor kernel uses two different drivers.

Regards
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@...el32.net                 http://www.aurel32.net