linux-kernel - Re: [PATCH v4 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 15:35:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Raul E Rangel <rrangel@...omium.org>
Cc:     linux-acpi@...r.kernel.org, linux-input@...r.kernel.org,
        timvp@...gle.com, hdegoede@...hat.com, rafael@...nel.org,
        mario.limonciello@....com, jingle.wu@....com.tw,
        mika.westerberg@...ux.intel.com, dmitry.torokhov@...il.com,
        linus.walleij@...aro.org, Dan Williams <dan.j.williams@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Len Brown <lenb@...nel.org>,
        Terry Bowman <terry.bowman@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 06/13] ACPI: resources: Add wake_capable parameter to
 acpi_dev_irq_flags

On Mon, Sep 19, 2022 at 09:59:08AM -0600, Raul E Rangel wrote:
> ACPI IRQ/Interrupt resources contain a bit that describes if the
> interrupt should wake the system. This change exposes that bit via
> a new IORESOURCE_IRQ_WAKECAPABLE flag. Drivers should check this flag
> before arming an IRQ to wake the system.

(A nit-pick, but because of other patch comment)

...

> -			acpi_dev_get_irqresource(res, ext_irq->interrupts[index],
> -					 ext_irq->triggering, ext_irq->polarity,
> -					 ext_irq->shareable, false);
> +			acpi_dev_get_irqresource(res,
> +						 ext_irq->interrupts[index],
> +						 ext_irq->triggering,
> +						 ext_irq->polarity,
> +						 ext_irq->shareable,
> +						 ext_irq->wake_capable,
> +						 false);

I understand this is done by a script, but it's unrelated indentation changes,
please just change what is related, like:

-					 ext_irq->shareable, false);
+					 ext_irq->shareable, ext_irq->wake_capable,
+					 false);

-- 
With Best Regards,
Andy Shevchenko