linux-kernel - Re: [PATCH] mm/secretmem: remove reduntant return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4e99ea3-302d-b173-27f1-92c38ddaca8c@huawei.com>
Date:   Tue, 20 Sep 2022 20:35:30 +0800
From:   xiujianfeng <xiujianfeng@...wei.com>
To:     David Hildenbrand <david@...hat.com>, <akpm@...ux-foundation.org>
CC:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/secretmem: remove reduntant return value

Hi,

在 2022/9/20 20:10, David Hildenbrand 写道:
> On 20.09.22 03:22, Xiu Jianfeng wrote:
>> The return value @ret is always 0, so remove it and return 0 directly.
>>
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
>> ---
>>   mm/secretmem.c | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/mm/secretmem.c b/mm/secretmem.c
>> index 6a44efb673b2..04c3ac9448a1 100644
>> --- a/mm/secretmem.c
>> +++ b/mm/secretmem.c
>> @@ -278,10 +278,8 @@ static struct file_system_type secretmem_fs = {
>>   static int __init secretmem_init(void)
>>   {
>> -    int ret = 0;
>> -
>>       if (!secretmem_enable)
>> -        return ret;
>> +        return 0;
>>       secretmem_mnt = kern_mount(&secretmem_fs);
>>       if (IS_ERR(secretmem_mnt))
> 
> On top of which tree is that?
> 
> 6.0-rc6 has here:
> 
> if (IS_ERR(secretmem_mnt))
>      ret = PTR_ERR(secretmem_mnt);
> 
Sorry, it's on linux-next tree, I should have used [PATCH -next]:)