linux-kernel - Re: [PATCH v2] riscv: support update_mmu_tlb() for riscv

Open Source and information security mailing list archives

Message-ID: <Yy4pBHm1fZ3oM/m5@spud>
Date:   Fri, 23 Sep 2022 22:45:40 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Jinyu Tang <tjytimi@....com>
Cc:     paul.walmsley@...ive.com, ajones@...tanamicro.com,
        palmer@...belt.com, aou@...s.berkeley.edu,
        conor.dooley@...rochip.com, anup@...infault.org,
        alexandre.ghiti@...onical.com, guoren@...nel.org,
        akpm@...ux-foundation.org, heiko@...ech.de, tongtiangen@...wei.com,
        sunnanyong@...wei.com, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, falcon@...ylab.org
Subject: Re: [PATCH v2] riscv: support update_mmu_tlb() for riscv

Hey Jinyu,
Firstly, the "for riscv" in the title is redundant and can be dropped.

On Sun, Sep 18, 2022 at 01:59:40PM +0800, Jinyu Tang wrote:
> Add macro definition to support updata_mmu_tlb() for riscv,
                                       ^
				s/updata/update/

> this function is from commit:7df676974359 ("mm/memory.c:Update
> local TLB if PTE entry exists").

So, and this just may be may lack of knowledge showing, but I don't
really understand _why_ we need this change. Your commit message should
explain why you are making the change rather than just repeating what
you are doing since that is obvious from the diff.

Only MIPS seems to have this define, so your commit message needs to
explain what it is about RISC-V that means we need it when all bar one
arch does not.

Thanks,
Conor.

> 
> Signed-off-by: Jinyu Tang <tjytimi@....com>
> Reviewed-by: Andrew Jones <ajones@...tanamicro.com>
> ---
> v1 -> v2: 
> 
> Change the format with the help from Andrew Jones and Conor Dooley.
> 
>  arch/riscv/include/asm/pgtable.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index 7ec936910a96..c61ae83aadee 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -418,6 +418,9 @@ static inline void update_mmu_cache(struct vm_area_struct *vma,
>  	local_flush_tlb_page(address);
>  }
>  
> +#define __HAVE_ARCH_UPDATE_MMU_TLB
> +#define update_mmu_tlb update_mmu_cache
> +
>  static inline void update_mmu_cache_pmd(struct vm_area_struct *vma,
>  		unsigned long address, pmd_t *pmdp)
>  {
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives