linux-kernel - Re: [PATCH -next] tty: moxa: add missing pci_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yy2C1gKxIENxMiT3@kroah.com>
Date:   Fri, 23 Sep 2022 11:56:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     ruanjinjie <ruanjinjie@...wei.com>
Cc:     jirislaby@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] tty: moxa: add missing pci_disable_device()

On Fri, Sep 23, 2022 at 05:25:30PM +0800, ruanjinjie wrote:
> Driver should call pci_disable_device() if it returns from
> moxa_pci_probe() with error.

Why?

That is not a normal thing to do, as you can disable other PCI devices
attached to it, right?

> Meanwhile, the driver calls pci_enable_device() in
> moxa_pci_probe(), but never calls pci_disable_device() during removal.

And is that really a problem?

> 
> Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>
> ---
>  drivers/tty/moxa.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Do you have this hardware to test with?

How did you find this issue?

thanks,

greg k-h