linux-kernel - Re: [PATCH v2 1/1] serdev: Replace poll loop by readx_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Sep 2022 13:57:29 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Magnus Damm <damm+renesas@...nsource.se>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 1/1] serdev: Replace poll loop by readx_poll_timeout()
 macro

On Fri, Sep 23, 2022 at 08:10:48PM +0300, Andy Shevchenko wrote:
> The readx_poll_timeout() consolidates the necessary code under
> macro. Replace current code with it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2: dropped TODO: in the Subject line
>  include/linux/serdev.h | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/include/linux/serdev.h b/include/linux/serdev.h
> index 66f624fc618c..69d9c3188065 100644
> --- a/include/linux/serdev.h
> +++ b/include/linux/serdev.h
> @@ -7,9 +7,11 @@
>  
>  #include <linux/types.h>
>  #include <linux/device.h>
> +#include <linux/iopoll.h>
>  #include <linux/uaccess.h>
>  #include <linux/termios.h>
>  #include <linux/delay.h>
> +#include <vdso/time64.h>

Ick, just for USEC_PER_MSEC?  That should be in units.h, not burried in
a vdso-only .h file.  This feels wrong, sorry.

greg k-h