linux-kernel - Re: [PATCH v2 1/1] serdev: Replace poll loop by readx_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2022 13:48:48 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Magnus Damm <damm+renesas@...nsource.se>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 1/1] serdev: Replace poll loop by readx_poll_timeout()
 macro

On Sat, Sep 24, 2022 at 01:57:29PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 23, 2022 at 08:10:48PM +0300, Andy Shevchenko wrote:
> > The readx_poll_timeout() consolidates the necessary code under
> > macro. Replace current code with it.

...

> > +#include <vdso/time64.h>
> 
> Ick, just for USEC_PER_MSEC?  That should be in units.h, not burried in
> a vdso-only .h file.  This feels wrong, sorry.

Why are you asking me about this? It was not my choice and it was made
a couple of years ago (see [1]).

As a solution I can just drop using that constant in v3.

[1]: b72a9c5e023b ("linux/time64.h: Extract common header for vDSO")


-- 
With Best Regards,
Andy Shevchenko