linux-kernel - Re: [PATCH] video: fbdev: controlfb: Remove the unused function VAR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <abde96de-193c-fa78-53c6-e65629b419e9@gmx.de>
Date:   Sun, 25 Sep 2022 13:11:22 +0200
From:   Helge Deller <deller@....de>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] video: fbdev: controlfb: Remove the unused function
 VAR_MATCH()

On 9/14/22 12:22, Jiapeng Chong wrote:
> The function VAR_MATCH is defined in the controlfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/controlfb.c:111:19: warning: unused function 'VAR_MATCH'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2153
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

applied.

Thanks,
Helge


> ---
>   drivers/video/fbdev/controlfb.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c
> index aba46118b208..6bbcd9fc864e 100644
> --- a/drivers/video/fbdev/controlfb.c
> +++ b/drivers/video/fbdev/controlfb.c
> @@ -108,13 +108,6 @@ static inline int PAR_EQUAL(struct fb_par_control *x, struct fb_par_control *y)
>   	return (!DIRTY(cmode) && !DIRTY(xres) && !DIRTY(yres)
>   		&& !DIRTY(vxres) && !DIRTY(vyres));
>   }
> -static inline int VAR_MATCH(struct fb_var_screeninfo *x, struct fb_var_screeninfo *y)
> -{
> -	return (!DIRTY(bits_per_pixel) && !DIRTY(xres)
> -		&& !DIRTY(yres) && !DIRTY(xres_virtual)
> -		&& !DIRTY(yres_virtual)
> -		&& !DIRTY_CMAP(red) && !DIRTY_CMAP(green) && !DIRTY_CMAP(blue));
> -}
>
>   struct fb_info_control {
>   	struct fb_info		info;