lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a4146b46-4936-80c9-8839-45bbe2c39cb6@gmx.de>
Date:   Sun, 25 Sep 2022 13:12:19 +0200
From:   Helge Deller <deller@....de>
To:     Colin Ian King <colin.i.king@...il.com>,
        Bernie Thompson <bernie@...gable.com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: remove redundant initialization to variable
 identical

On 9/7/22 15:50, Colin Ian King wrote:
> The variable identical is being initialized with a value that is never
> read. The variable is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan-build warning:
> drivers/video/fbdev/udlfb.c:373:6: warning: Value stored to 'identical'
> during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

applied.

Thanks!
Helge

> ---
>   drivers/video/fbdev/udlfb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
> index c863244ef12c..216d49c9d47e 100644
> --- a/drivers/video/fbdev/udlfb.c
> +++ b/drivers/video/fbdev/udlfb.c
> @@ -370,7 +370,7 @@ static int dlfb_trim_hline(const u8 *bback, const u8 **bfront, int *width_bytes)
>   	const unsigned long *back = (const unsigned long *) bback;
>   	const unsigned long *front = (const unsigned long *) *bfront;
>   	const int width = *width_bytes / sizeof(unsigned long);
> -	int identical = width;
> +	int identical;
>   	int start = width;
>   	int end = width;
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ