linux-kernel - Re: [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220925142954.GA1752068@roeck-us.net>
Date:   Sun, 25 Sep 2022 07:29:54 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, yuji2.ishikawa@...hiba.co.jp,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update
 the common clock properties

On Wed, May 25, 2022 at 09:46:05AM +0900, Nobuhiro Iwamatsu wrote:
> The clock for this driver switched to the common clock controller driver.
> Therefore, update common clock properties for watchdog in the binding document.
> And this matched this example with the actual dts.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>
> Acked-by: Rob Herring <robh@...nel.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> 
>  v3: doesn't remove timeout-sec.
>  v2: send to linux-watchdog.
> 
>  .../bindings/watchdog/toshiba,visconti-wdt.yaml      | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> index 690e19ce4b87..eba083822d1f 100644
> --- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> @@ -35,20 +35,16 @@ additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/toshiba,tmpv770x.h>
> +
>      soc {
>          #address-cells = <2>;
>          #size-cells = <2>;
>  
> -        wdt_clk: wdt-clk {
> -            compatible = "fixed-clock";
> -            clock-frequency = <150000000>;
> -            #clock-cells = <0>;
> -        };
> -
> -        watchdog@...30000 {
> +        wdt: watchdog@...30000 {
>              compatible = "toshiba,visconti-wdt";
>              reg = <0 0x28330000 0 0x1000>;
> -            clocks = <&wdt_clk>;
>              timeout-sec = <20>;
> +            clocks = <&pismu TMPV770X_CLK_WDTCLK>;
>          };
>      };