linux-kernel - Re: [PATCH] mm: fix misuse of update_mmu_cache() in do_anonymous

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3A09E40A-E2C5-4C6F-8550-DD0E17B7DAB9@linux.dev>
Date:   Sun, 25 Sep 2022 09:43:34 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     Qi Zheng <zhengqi.arch@...edance.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux MM <linux-mm@...ck.org>, linux-kernel@...r.kernel.org,
        chris@...kel.net, jcmvbkbc@...il.com, maobibo@...ngson.cn
Subject: Re: [PATCH] mm: fix misuse of update_mmu_cache() in
 do_anonymous_page()



> On Sep 24, 2022, at 13:32, Qi Zheng <zhengqi.arch@...edance.com> wrote:
> 
> As message in commit 7df676974359 ("mm/memory.c: Update local TLB
> if PTE entry exists") said, we should update local TLB only on the
> second thread. So fix the misuse of update_mmu_cache() by using
> update_mmu_tlb() in the do_anonymous_page().
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

The change looks good to me. However, I am not sure what is the user-visible
effect to xtensa users. So Cc xtensa’s maintainer and the author of 7df676974359
to double check this.


But anyway:

Reviewed-by: Muchun Song <songmuchun@...edance.com>