linux-kernel - Re: [PATCH] KVM: arm64: vgic: Remove duplicate check in update_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2022 09:21:08 +1000
From:   Gavin Shan <gshan@...hat.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     kvmarm@...ts.cs.columbia.edu, linux-kernel@...r.kernel.org,
        will@...nel.org, eric.auger@...hat.com, yuzhe@...china.com,
        oliver.upton@...ux.dev, shan.gavin@...il.com,
        James Morse <james.morse@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Alexandru Elisei <Alexandru.Elisei@....com>
Subject: Re: [PATCH] KVM: arm64: vgic: Remove duplicate check in
 update_affinity_collection()

Hi Marc,

On 9/24/22 9:56 PM, Marc Zyngier wrote:
> Side note: please make sure you always Cc all the KVM/arm64 reviewers
> when sending patches (now added).
> 

Sure. The reason, why I didn't run './scripts/get_maintainer.pl' to get
all reviewers, is the patch is super simple one :)

> On Fri, 23 Sep 2022 07:54:47 +0100,
> Gavin Shan <gshan@...hat.com> wrote:
>>
>> The ITS collection is guranteed to be !NULL when update_affinity_collection()
>> is called. So we needn't check ITE's collection with NULL because the
>> check has been included to the later one.
> 
> It took me a while to understand what you meant by this: the 'coll'
> parameter to update_affinity_collection() is never NULL, so comparing
> it with 'ite->collection' is enough to cover both the NULL case and
> the "another collection" case.
> 
> If you agree with this, I can directly fix the commit message when
> applying the patch.
> 

Yes, the commit message is accurate and correct. Please help to apply
your commit message directly :)

Thanks,
Gavin