linux-kernel - Re: [PATCH v2 6/8] scsi: libsas: use sas_phy_match_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88299002-3aa1-d208-0451-d5b8601c0edc@huawei.com>
Date:   Mon, 26 Sep 2022 12:43:18 +0100
From:   John Garry <john.garry@...wei.com>
To:     Jason Yan <yanaijie@...wei.com>, <martin.petersen@...cle.com>,
        <jejb@...ux.ibm.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <hare@...e.com>, <hch@....de>, <bvanassche@....org>,
        <jinpu.wang@...ud.ionos.com>
Subject: Re: [PATCH v2 6/8] scsi: libsas: use sas_phy_match_dev_addr() instead
 of open coded

On 24/09/2022 08:34, Jason Yan wrote:
> @@ -2115,8 +2109,7 @@ int sas_find_attached_phy(struct expander_device *ex_dev,
>   
>   	for (phy_id = 0; phy_id < ex_dev->num_phys; phy_id++) {
>   		phy = &ex_dev->ex_phy[phy_id];
> -		if (SAS_ADDR(phy->attached_sas_addr)
> -			== SAS_ADDR(dev->sas_addr))
> +		if (sas_phy_match_dev_addr(dev, phy))

It would be nice if the series was arranged such that 
sas_phy_match_dev_addr() is available when you introduce 
sas_phy_match_dev_addr()

>   			return phy_id;
>   	}

Thanks,
John