linux-kernel - Re: [PATCH v6 0/5] Define EINVAL as device/domain incompatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzGZqXCuw6yoXBla@8bytes.org>
Date:   Mon, 26 Sep 2022 14:23:05 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     Nicolin Chen <nicolinc@...dia.com>
Cc:     will@...nel.org, robin.murphy@....com, jgg@...dia.com,
        kevin.tian@...el.com, quic_jjohnson@...cinc.com,
        suravee.suthikulpanit@....com, robdclark@...il.com,
        dwmw2@...radead.org, baolu.lu@...ux.intel.com,
        yong.wu@...iatek.com, matthias.bgg@...il.com, orsonzhai@...il.com,
        baolin.wang@...ux.alibaba.com, zhang.lyra@...il.com,
        thierry.reding@...il.com, vdumpa@...dia.com, jonathanh@...dia.com,
        jean-philippe@...aro.org, shameerali.kolothum.thodi@...wei.com,
        tglx@...utronix.de, christophe.jaillet@...adoo.fr,
        thunder.leizhen@...wei.com, yangyingliang@...wei.com,
        quic_saipraka@...cinc.com, jon@...id-run.com,
        iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-tegra@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v6 0/5] Define EINVAL as device/domain incompatibility

Hi Nicolin,

On Fri, Sep 23, 2022 at 12:16:29AM -0700, Nicolin Chen wrote:
> This series is to replace the previous EMEDIUMTYPE patch in a VFIO series:
> https://lore.kernel.org/kvm/Yxnt9uQTmbqul5lf@8bytes.org/

\o/

> Nicolin Chen (5):
>   iommu/amd: Drop unnecessary checks in amd_iommu_attach_device()
>   iommu: Add return value rules to attach_dev op and APIs
>   iommu: Regulate EINVAL in ->attach_dev callback functions
>   iommu: Use EINVAL for incompatible device/domain in ->attach_dev
>   iommu: Propagate return value in ->attach_dev callback functions

This looks good to me, but I'd like to have the SMMU people have a look
at patch 4. And I think it is too late for this to make it into 6.1, so
please re-send after 6.1-rc1 is out.

Thanks,

	Joerg