linux-kernel - Re: [PATCH linux-next] backlight: lp8788: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzGo2o3bVLnOiQJr@maple.lan>
Date:   Mon, 26 Sep 2022 14:27:54 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     cgel.zte@...il.com
Cc:     lee@...nel.org, jingoohan1@...il.com, deller@....de,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ye xingchen <ye.xingchen@....com.cn>
Subject: Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to
 instead of scnprintf()

On Fri, Sep 23, 2022 at 06:35:33AM +0000, cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  drivers/video/backlight/lp8788_bl.c | 2 +-

This one has the subject right and is a good change. However I'd still
prefer it as a single patchset that fixes *all* instances of this code
pattern.


Daniel.