linux-kernel - Re: [PATCH linux-next] backlight: lp8788: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPOBaE7sMPR9YgfLV2Y12E=jxO72PhOzJ=G=tdTkN-Af1CMuRA@mail.gmail.com>
Date:   Mon, 26 Sep 2022 11:49:30 -0700
From:   Han Jingoo <jingoohan1@...il.com>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     cgel.zte@...il.com, lee@...nel.org, deller@....de,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ye xingchen <ye.xingchen@....com.cn>
Subject: Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead
 of scnprintf()

On Mon, Sep 26, 2022 Daniel Thompson <daniel.thompson@...aro.org> wrote:
>
> On Fri, Sep 23, 2022 at 06:35:33AM +0000, cgel.zte@...il.com wrote:
> > From: ye xingchen <ye.xingchen@....com.cn>
> >
> > Replace the open-code with sysfs_emit() to simplify the code.
> >
> > Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> > ---
> >  drivers/video/backlight/lp8788_bl.c | 2 +-
>
> This one has the subject right and is a good change. However I'd still
> prefer it as a single patchset that fixes *all* instances of this code
> pattern.

Yes, I agree with Daniel's opinion.

Xingchen,
Please make a "Single" patch for including "ALL" fixes
for this pattern in the 'drivers/video/backlight' directory.
Thank you.

Best regards,
Jingoo Han

>
>
> Daniel.