linux-kernel - Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13105309.uLZWGnKmhe@g550jk>
Date:   Mon, 26 Sep 2022 17:07:56 +0200
From:   Luca Weiss <luca@...tu.xyz>
To:     neil.armstrong@...aro.org, linux-arm-msm@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

Hi Krzysztof,

On Montag, 26. September 2022 12:29:11 CEST Krzysztof Kozlowski wrote:
> On 26/09/2022 12:04, Neil Armstrong wrote:
> > On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
> >>>   		};
> >>> 
> >>> -		usb_id: misc@900 {
> >>> +		usb_id: extcon@900 {
> >> 
> >> Why? extcon is Linux specific name and should not be added to DTS.
> >> Anything requires it?
> > 
> > It matches the current dt bindings:
> Then instead maybe let's fix it in the bindings and DTS?

What node name do you propose? I doubt "misc" is a better name as it really 
doesn't describe anything so I don't really have a suggestion here..

Regards
Luca

> 
> Best regards,
> Krzysztof