linux-kernel - Re: [PATCH -next] block/swim3: add __init annotation to module init func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4463371a-2b71-1153-7814-fdff59eb99cd@wanadoo.fr>
Date:   Mon, 26 Sep 2022 19:37:53 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     ruanjinjie <ruanjinjie@...wei.com>, axboe@...nel.dk,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] block/swim3: add __init annotation to module init
 func

Le 26/09/2022 à 11:22, ruanjinjie a écrit :
> Add missing __init annotation to module init func.
> 
> Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>
> ---
>   drivers/block/swim3.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
> index da811a7da03f..1f65d506fbc9 100644
> --- a/drivers/block/swim3.c
> +++ b/drivers/block/swim3.c
> @@ -1278,7 +1278,7 @@ static struct macio_driver swim3_driver =
>   };
>   
>   
> -int swim3_init(void)
> +int __init swim3_init(void)
>   {
>   	macio_register_driver(&swim3_driver);
>   	return 0;

Hi,

unrelated, but should there be a swim3_exit() to call 
macio_register_driver(), as already done in some other drivers using 
these functions?

CJ