linux-kernel - Re: [PATCH -next] drm/ast: make ast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6d0fb6f-6fc3-3123-ee7c-7edac211dbf3@suse.de>
Date:   Mon, 26 Sep 2022 09:16:34 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     ruanjinjie <ruanjinjie@...wei.com>, airlied@...hat.com,
        airlied@...ux.ie, daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/ast: make ast_modeset static

Hi

Am 26.09.22 um 04:32 schrieb ruanjinjie:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset'
> was not declared. Should it be static?
> 
> Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>

Thank you. Added to drm-misc-next.

Best regards
Thomas

> ---
>   drivers/gpu/drm/ast/ast_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
> index 760b27971557..b9392f31e629 100644
> --- a/drivers/gpu/drm/ast/ast_drv.c
> +++ b/drivers/gpu/drm/ast/ast_drv.c
> @@ -39,7 +39,7 @@
>   
>   #include "ast_drv.h"
>   
> -int ast_modeset = -1;
> +static int ast_modeset = -1;
>   
>   MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>   module_param_named(modeset, ast_modeset, int, 0400);

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)