linux-kernel - Re: [PATCH -next] drm/ast: make ast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b237cfe9-7a8c-e884-2ec6-fbe1c6603f95@huawei.com>
Date:   Mon, 26 Sep 2022 15:38:28 +0800
From:   Ruan Jinjie <ruanjinjie@...wei.com>
To:     Thomas Zimmermann <tzimmermann@...e.de>, <airlied@...hat.com>,
        <airlied@...ux.ie>, <daniel@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/ast: make ast_modeset static

Thank you very much!

On 2022/9/26 15:16, Thomas Zimmermann wrote:
> Hi
> 
> Am 26.09.22 um 04:32 schrieb ruanjinjie:
>> The symbol is not used outside of the file, so mark it static.
>>
>> Fixes the following warning:
>>
>> drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset'
>> was not declared. Should it be static?
>>
>> Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>
> 
> Thank you. Added to drm-misc-next.
> 
> Best regards
> Thomas
> 
>> ---
>>   drivers/gpu/drm/ast/ast_drv.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_drv.c
>> b/drivers/gpu/drm/ast/ast_drv.c
>> index 760b27971557..b9392f31e629 100644
>> --- a/drivers/gpu/drm/ast/ast_drv.c
>> +++ b/drivers/gpu/drm/ast/ast_drv.c
>> @@ -39,7 +39,7 @@
>>     #include "ast_drv.h"
>>   -int ast_modeset = -1;
>> +static int ast_modeset = -1;
>>     MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>>   module_param_named(modeset, ast_modeset, int, 0400);
>