linux-kernel - Re: [PATCH] mm: fix misuse of update_mmu_cache() in do_anonymous

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1a6007d-24f2-5153-5382-f66391cbd0cb@bytedance.com>
Date:   Mon, 26 Sep 2022 16:41:19 +0800
From:   Qi Zheng <zhengqi.arch@...edance.com>
To:     David Hildenbrand <david@...hat.com>,
        Muchun Song <muchun.song@...ux.dev>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux MM <linux-mm@...ck.org>, linux-kernel@...r.kernel.org,
        chris@...kel.net, jcmvbkbc@...il.com, maobibo@...ngson.cn
Subject: Re: [PATCH] mm: fix misuse of update_mmu_cache() in
 do_anonymous_page()



On 2022/9/26 16:32, David Hildenbrand wrote:
> On 25.09.22 03:43, Muchun Song wrote:
>>
>>
>>> On Sep 24, 2022, at 13:32, Qi Zheng <zhengqi.arch@...edance.com> wrote:
>>>
>>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB
>>> if PTE entry exists") said, we should update local TLB only on the
>>> second thread. So fix the misuse of update_mmu_cache() by using
>>> update_mmu_tlb() in the do_anonymous_page().
>>>
>>> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
>>
>> The change looks good to me. However, I am not sure what is the 
>> user-visible
>> effect to xtensa users. So Cc xtensa’s maintainer and the author of 
>> 7df676974359
>> to double check this.
> 
> And if there is one, do we have a fixes tag?

IIUC, there's only a performance difference here, so maybe there's no
need to add the fixes tag?

> 

-- 
Thanks,
Qi