linux-kernel - Re: [PATCH -next] clk: imx: scu: fix memleak on platform_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b7e7b14-d7bd-4d58-3ace-d243c4f038d9@huawei.com>
Date:   Mon, 26 Sep 2022 17:13:02 +0800
From:   "linyujun (C)" <linyujun809@...wei.com>
To:     <abelvesa@...nel.org>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <shawnguo@...nel.org>,
        <s.hauer@...gutronix.de>, <kernel@...gutronix.de>,
        <festevam@...il.com>, <linux-imx@....com>, <aisheng.dong@....com>
CC:     <linux-clk@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] clk: imx: scu: fix memleak on platform_device_add()
 fails

kindly ping

在 2022/9/14 11:32, Lin Yujun 写道:
> No error handling is performed when platform_device_add()
> fails. Add error processing before return, and modified
> the return value.
>
> Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support")
> Signed-off-by: Lin Yujun <linyujun809@...wei.com>
> ---
>   drivers/clk/imx/clk-scu.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index c56e406138db..1e6870f3671f 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -695,7 +695,11 @@ struct clk_hw *imx_clk_scu_alloc_dev(const char *name,
>   		pr_warn("%s: failed to attached the power domain %d\n",
>   			name, ret);
>   
> -	platform_device_add(pdev);
> +	ret = platform_device_add(pdev);
> +	if (ret) {
> +		platform_device_put(pdev);
> +		return ERR_PTR(ret);
> +	}
>   
>   	/* For API backwards compatiblilty, simply return NULL for success */
>   	return NULL;