linux-kernel - Re: [PATCH v3 1/2] dt-bindings: clock: add QCOM SM6115 display clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220927030946.5acxedwvut6ifdmx@builder.lan>
Date:   Mon, 26 Sep 2022 22:09:46 -0500
From:   Bjorn Andersson <andersson@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Adam Skladowski <a39.skl@...il.com>, phone-devel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: add QCOM SM6115 display clock
 bindings

On Tue, Sep 13, 2022 at 10:26:20AM -0500, Rob Herring wrote:
> On Sun, Sep 11, 2022 at 06:46:18PM +0200, Adam Skladowski wrote:
> > Add device tree bindings for display clock controller for
> > Qualcomm Technology Inc's SM6115 SoC.
> > 
> > Signed-off-by: Adam Skladowski <a39.skl@...il.com>
> > ---
> >  .../bindings/clock/qcom,sm6115-dispcc.yaml    | 70 +++++++++++++++++++
> >  .../dt-bindings/clock/qcom,sm6115-dispcc.h    | 36 ++++++++++
> >  2 files changed, 106 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
> >  create mode 100644 include/dt-bindings/clock/qcom,sm6115-dispcc.h
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
> > new file mode 100644
> > index 000000000000..a6bf363b5015
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/qcom,sm6115-dispcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Display Clock Controller Binding for SM6115
> 
> s/Binding //
> 
> > +
> > +maintainers:
> > +  - Bjorn Andersson <andersson@...nel.org>
> > +
> > +description: |
> 
> Don't need '|' when no formatting to preserve.
> 

This follows the other dispcc bindings, where I think the intention is
to keep the formatting over "See also". In contrast to the other dispcc
bindings the "See also" has a ':' at the end in this proposal...

> With those fixes,
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

I took the liberty of fixing up the description to align with the others
and applied this, with your R-b.

Regards,
Bjorn