linux-kernel - Re: [PATCH 5.19 014/207] Revert "usb: add quirks for Lenovo OneLink+ Dock"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9d9651b-2561-03ce-8076-5b471929ff2d@kernel.org>
Date:   Tue, 27 Sep 2022 07:23:46 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org, Oliver Neukum <oneukum@...e.com>,
        Jean-Francois Le Fillatre <jflf_kernel@....com>,
        stable <stable@...nel.org>, Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.19 014/207] Revert "usb: add quirks for Lenovo OneLink+
 Dock"

I wonder, does it make sense to queue the commit (as 011/207) and 
immediately its revert (the patch below) in a single release? I doubt 
that...

The same holds for 012 (patch) + 015 (revert).

On 26. 09. 22, 12:10, Greg Kroah-Hartman wrote:
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> [ Upstream commit 58bfe7d8e31014d7ce246788df99c56e3cfe6c68 ]
> 
> This reverts commit 3d5f70949f1b1168fbb17d06eb5c57e984c56c58.
> 
> The quirk does not work properly, more work is needed to determine what
> should be done here.
> 
> Reported-by: Oliver Neukum <oneukum@...e.com>
> Cc: Jean-Francois Le Fillatre <jflf_kernel@....com>
> Cc: stable <stable@...nel.org>
> Fixes: 3d5f70949f1b ("usb: add quirks for Lenovo OneLink+ Dock")
> Link: https://lore.kernel.org/r/9a17ea86-079f-510d-e919-01bc53a6d09f@gmx.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>   drivers/usb/core/quirks.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 999b7c9697fc..f99a65a64588 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -437,10 +437,6 @@ static const struct usb_device_id usb_quirk_list[] = {
>   	{ USB_DEVICE(0x1532, 0x0116), .driver_info =
>   			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>   
> -	/* Lenovo ThinkPad OneLink+ Dock twin hub controllers (VIA Labs VL812) */
> -	{ USB_DEVICE(0x17ef, 0x1018), .driver_info = USB_QUIRK_RESET_RESUME },
> -	{ USB_DEVICE(0x17ef, 0x1019), .driver_info = USB_QUIRK_RESET_RESUME },
> -
>   	/* Lenovo USB-C to Ethernet Adapter RTL8153-04 */
>   	{ USB_DEVICE(0x17ef, 0x720c), .driver_info = USB_QUIRK_NO_LPM },
>   

-- 
js
suse labs